Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761215AbYBOSwk (ORCPT ); Fri, 15 Feb 2008 13:52:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760081AbYBOSwW (ORCPT ); Fri, 15 Feb 2008 13:52:22 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:54646 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759824AbYBOSwU (ORCPT ); Fri, 15 Feb 2008 13:52:20 -0500 Message-ID: <47B5DF56.9040707@garzik.org> Date: Fri, 15 Feb 2008 13:52:06 -0500 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Tejun Heo CC: Ingo Molnar , Arjan van de Ven , linux-kernel@vger.kernel.org, Linus Torvalds , Mark Lord , Alan Cox , IDE/ATA development list Subject: Re: [libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure References: <20080212081816.GA17820@elte.hu> <20080212071452.5c58ae6d@laptopd505.fenrus.org> <20080213090159.GA21614@elte.hu> <47B2B653.7020408@gmail.com> In-Reply-To: <47B2B653.7020408@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.3 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 760 Lines: 22 Tejun Heo wrote: > ata_host_detach() detaches an attached port and shouldn't be called on > a port which hasn't been attached yet. pata_legacy incorrectly calls > ata_host_detach() on unattached port after initialization failure > causing oops. Fix it. > > Signed-off-by: Tejun Heo > Cc: Alan Cox > Cc: Ingo Molnar > Cc: Arjan van de Ven > --- > drivers/ata/pata_legacy.c | 2 -- > 1 file changed, 2 deletions(-) applied -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/