Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765565AbYBOU7d (ORCPT ); Fri, 15 Feb 2008 15:59:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764361AbYBOU66 (ORCPT ); Fri, 15 Feb 2008 15:58:58 -0500 Received: from general-networks3.cust.sloane.cz ([88.146.176.14]:56091 "EHLO server.generalnetworks.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757189AbYBOU65 (ORCPT ); Fri, 15 Feb 2008 15:58:57 -0500 From: Jiri Slaby To: linville@tuxdriver.com Cc: , linux-wireless@vger.kernel.org, ath5k-devel@lists.ath5k.org, Jiri Slaby , Nick Kossifidis , "Luis R. Rodriguez" Subject: [PATCH 1/3] WDEV: ath5k, fix lock imbalance Date: Fri, 15 Feb 2008 21:58:51 +0100 Message-Id: <1203109133-32217-1-git-send-email-jirislaby@gmail.com> X-Mailer: git-send-email 1.5.3.8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1098 Lines: 32 Omitted lock causes sparse warning drivers/net/wireless/ath5k/base.c:1682:1: warning: context imbalance in 'ath5k_tasklet_rx' - different lock contexts for basic block Add the lock to the guilty fail path. Signed-off-by: Jiri Slaby Cc: Nick Kossifidis Cc: Luis R. Rodriguez --- drivers/net/wireless/ath5k/base.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c index ddc8714..49d38e8 100644 --- a/drivers/net/wireless/ath5k/base.c +++ b/drivers/net/wireless/ath5k/base.c @@ -1715,6 +1715,7 @@ ath5k_tasklet_rx(unsigned long data) break; else if (unlikely(ret)) { ATH5K_ERR(sc, "error in processing rx descriptor\n"); + spin_unlock(&sc->rxbuflock); return; } -- 1.5.3.8 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/