Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758801AbYBOWIT (ORCPT ); Fri, 15 Feb 2008 17:08:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754133AbYBOWIF (ORCPT ); Fri, 15 Feb 2008 17:08:05 -0500 Received: from py-out-1112.google.com ([64.233.166.183]:8050 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753760AbYBOWID (ORCPT ); Fri, 15 Feb 2008 17:08:03 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=lZ6np3+nR4qJ6fkd4JTiWmSHIMDePxSn/2jEXd/t/g+A3SiWvgUVfe2mh6WvViZ1Qn4sOituYW5wXV5ddHiOuQnrML2fflDFr100TOmbIg8ypCvOulAdpzkBGFupG3h70D/uUbey2VFBCkcUYQoliqJNmPAsFUR12TJI8kDYGts= Message-ID: <43e72e890802151408g35fa2e49r5eb8557e4a5bbce4@mail.gmail.com> Date: Fri, 15 Feb 2008 17:08:00 -0500 From: "Luis R. Rodriguez" To: "Jiri Slaby" Subject: Re: [PATCH 2/3] WDEV, ath5k, don't return int from bool function Cc: linville@tuxdriver.com, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, ath5k-devel@lists.ath5k.org, "Nick Kossifidis" In-Reply-To: <1203109133-32217-2-git-send-email-jirislaby@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1203109133-32217-1-git-send-email-jirislaby@gmail.com> <1203109133-32217-2-git-send-email-jirislaby@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 853 Lines: 27 On Fri, Feb 15, 2008 at 3:58 PM, Jiri Slaby wrote: > -static bool > +static int > ath5k_hw_setup_xr_tx_desc(struct ath5k_hw *ah, struct ath5k_desc *desc, > unsigned int tx_rate1, u_int tx_tries1, u_int tx_rate2, u_int tx_tries2, > unsigned int tx_rate3, u_int tx_tries3) > @@ -3773,10 +3773,10 @@ ath5k_hw_setup_xr_tx_desc(struct ath5k_hw *ah, struct ath5k_desc *desc, > > #undef _XTX_TRIES > > - return true; > + return 1; > } > > - return false; > + return 0; > } Shouldn't we then treat 0 as OK? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/