Date: Sat, 16 Feb 2008 13:24:07 +0100
From: Sam Ravnborg <sam@ravnborg.org>
To: Olof Johansson <olof@lixom.net>
Cc: Jonas Bonn <jonas@southpole.se>, linux-kernel@vger.kernel.org
Subject: Re: pci_device_id definition cleanups
Message-ID: <20080216122407.GA11753@uranus.ravnborg.org>
References: <1203117700.16761.9.camel@satguru> <20080216022336.GA7740@uranus.ravnborg.org> <20080216052737.GA18277@lixom.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080216052737.GA18277@lixom.net>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1724
Lines: 46

On Fri, Feb 15, 2008 at 11:27:38PM -0600, Olof Johansson wrote:
> On Sat, Feb 16, 2008 at 03:23:36AM +0100, Sam Ravnborg wrote:
> > On Sat, Feb 16, 2008 at 12:21:40AM +0100, Jonas Bonn wrote:
> > > I've done some work on cleaning up the definitions of pci_device_id to
> > > make them "static const" (where possible) and to make sure they go into
> > > __devinitconst.  There are about 350 changes of the type shown in the
> > > diff at the end of this mail.
> > > 
> > > ???All these changes are in my public GIT tree at:
> > > 
> > > git://www.southpole.se/~jonas/git/linux.git
> > > 
> > > (Based on 2.6.25-rc2)
> > > 
> > > In addition to these pci_device_id changes, there are a few changesets
> > > that move "const" data from __devinitdata to __devinitconst.
> > > 
> > > The tree above builds with both allmodconfig and allyesconfig.
> > 
> > Hi Jonas.
> > 
> > Can I ask you to try the same with ARCH=powerpc
> > (or alpha or ia64).
> > Becasue it is for these architectures we see issues with
> > defining data const.
> 
> I pulled his tree and tried building on powerpc w/ gcc 4.3, it passed.

Thanks for testing!

> 
> I'm not too excited about the extremely long open-coded variable
> definitions everywhere now though. Wouldn't it be better to just do a
> macro for it?
> 
> Something like:
> 
> #define PCI_DEVICE_TABLE(_var) static const struct pci_device_id _var[] __devinitconst
Fully agreed - but this is Greg's area I guess. Try submitting him a patch.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/