Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756558AbYBQEOX (ORCPT ); Sat, 16 Feb 2008 23:14:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753552AbYBQEOQ (ORCPT ); Sat, 16 Feb 2008 23:14:16 -0500 Received: from smtpq2.groni1.gr.home.nl ([213.51.130.201]:51662 "EHLO smtpq2.groni1.gr.home.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753434AbYBQEOP (ORCPT ); Sat, 16 Feb 2008 23:14:15 -0500 Message-ID: <47B7B518.7060509@keyaccess.nl> Date: Sun, 17 Feb 2008 05:16:24 +0100 From: Rene Herman User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: "H. Peter Anvin" CC: Roel Kluin <12o3l@tiscali.nl>, lkml Subject: Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x) References: <47B70810.5030608@tiscali.nl> <47B732EF.4050504@zytor.com> <47B79D0D.2070808@keyaccess.nl> <47B7B081.8050306@zytor.com> In-Reply-To: <47B7B081.8050306@zytor.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.0 (-) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 30 On 17-02-08 04:56, H. Peter Anvin wrote: > Rene Herman wrote: >> On 16-02-08 20:01, H. Peter Anvin wrote: >>> Roel Kluin wrote: >>>> Not entirely sure who to send this to >>>> --- >>>> Replace !likely(x) by likely(!x) >>> >>> Whoa... >>> >>> Are you sure this is correct? >>> >>> !likely(x) is equivalent to unlikely(!x) >> >> Not with respect to its value I believe? likely(x) == !!(x), and >> unlikely(!x) == !!(!x) = !x, so conditions work out differently? > > You missed one ! sign: > > !likely(x) == !!!(x) == unlikely(!x) == !!(!(x)) Yup, sorry, misread. Rene. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/