Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756110AbYBQG0T (ORCPT ); Sun, 17 Feb 2008 01:26:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752533AbYBQG0J (ORCPT ); Sun, 17 Feb 2008 01:26:09 -0500 Received: from rgminet01.oracle.com ([148.87.113.118]:51956 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752556AbYBQG0I (ORCPT ); Sun, 17 Feb 2008 01:26:08 -0500 Date: Sat, 16 Feb 2008 22:25:40 -0800 From: Joel Becker To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Randy Dunlap Subject: Re: 2.6.25-rc2-mm1 Message-ID: <20080217062540.GB26206@mail.oracle.com> Mail-Followup-To: Andrew Morton , linux-kernel@vger.kernel.org, Randy Dunlap References: <20080216002522.9c4bd0fb.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080216002522.9c4bd0fb.akpm@linux-foundation.org> X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 41 On Sat, Feb 16, 2008 at 12:25:22AM -0800, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc2/2.6.25-rc2-mm1/ ... > +avoid-divides-in-bits_to_longs.patch Andrew, This patch, by introducing sizeof(long) in the BITS_TO_LONGS math, changes BITS_TO_LONGS from an int to a unsigned long. We noticed because this printk in fs/ocfs2/dlm/dlmdomain.c: mlog(ML_ERROR, "map_size %u != BITS_TO_LONGS(O2NM_MAX_NODES) %u\n", map_size, BITS_TO_LONGS(O2NM_MAX_NODES)); now gives this warning: fs/ocfs2/dlm/dlmdomain.c:938: warning: format '%u' expects type 'unsigned int', but argument 7 has type 'long unsigned int' We can tweak the printk once the patch goes to Linus, no worries. I just wanted to send a heads up in case the size change affects anything else. Joel -- There are morethings in heaven and earth, Horatio, Than are dreamt of in your philosophy. Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/