Subject: Re: [PATCH] Add PCI_DEVICE_TABLE macro
From: Jonas Bonn <jonas@southpole.se>
To: linux-kernel@vger.kernel.org
Cc: greg@kroah.com, olof@lixom.net, sam@ravnborg.com
In-Reply-To: <1203250205-5103-1-git-send-email-jonas@southpole.se>
References: <1203250205-5103-1-git-send-email-jonas@southpole.se>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-oTfWS+PKg7oy/dfnt7Yd"
Organization: South Pole Consulting AB
Date: Sun, 17 Feb 2008 13:13:24 +0100
Message-Id: <1203250404.24325.1.camel@satguru>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2086
Lines: 63


--=-oTfWS+PKg7oy/dfnt7Yd
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

I'm a bit uncertain whether the definition really should include the
'static' modifier... for most definitions of these tables this is ok,
but there are a couple of cases where it should not be static, so the
line would need to be open-coded again...

/Jonas

On Sun, 2008-02-17 at 13:10 +0100, Jonas Bonn wrote:
> The definitions of struct pci_device_id arrays should generally follow
> the same pattern across the entire kernel.  This macro defines this
> array as static const and puts it into the __devinitconst section.
>=20
> Signed-off-by: Jonas Bonn <jonas@southpole.se>
> ---
>  include/linux/pci.h |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
>=20
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 87195b6..487d31c 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -389,6 +389,14 @@ struct pci_driver {
>  #define	to_pci_driver(drv) container_of(drv, struct pci_driver, driver)
> =20
>  /**
> + * PCI_DEVICE_TABLE - macro used to describe a pci device table
> + *=20
> + * This macro is used to create a struct pci_device_id array in a generi=
c
> + * manner.
> + */
> +#define PCI_DEVICE_TABLE(_table) static const struct pci_device_id _tabl=
e[] __devinitconst
> +
> +/**
>   * PCI_DEVICE - macro used to describe a specific pci device
>   * @vend: the 16 bit PCI Vendor ID
>   * @dev: the 16 bit PCI Device ID

--=-oTfWS+PKg7oy/dfnt7Yd
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBHuCTk70gcjN2673MRAhdfAJwNfAvG9EKBKng3fXsAO8rdrJD+CgCeJF4V
SDEQY9u4xYR/HwBfvyhW/1w=
=YrWt
-----END PGP SIGNATURE-----

--=-oTfWS+PKg7oy/dfnt7Yd--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/