Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751584AbYBQRhZ (ORCPT ); Sun, 17 Feb 2008 12:37:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750730AbYBQRhM (ORCPT ); Sun, 17 Feb 2008 12:37:12 -0500 Received: from smtp4.pp.htv.fi ([213.243.153.38]:38384 "EHLO smtp4.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbYBQRhK (ORCPT ); Sun, 17 Feb 2008 12:37:10 -0500 Date: Sun, 17 Feb 2008 19:36:42 +0200 From: Adrian Bunk To: Bartlomiej Zolnierkiewicz Cc: "Robert P. J. Day" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] linux/hdsmart.h: fix goofups Message-ID: <20080217173642.GC1403@cs181133002.pp.htv.fi> References: <200802171807.57983.bzolnier@gmail.com> <200802171840.32180.bzolnier@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <200802171840.32180.bzolnier@gmail.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2314 Lines: 65 On Sun, Feb 17, 2008 at 06:40:31PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Sunday 17 February 2008, Robert P. J. Day wrote: > > On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wrote: > > > > > Fix goofups of commit 76166952bbc81dda1c8a8c14e75a2aa06f6c052c > > > (" is not used by kernel code"). > > > > > > Reported-by: "Robert P. J. Day" > > > Signed-off-by: Bartlomiej Zolnierkiewicz > > > --- > > > include/linux/hdsmart.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > Index: b/include/linux/hdsmart.h > > > =================================================================== > > > --- a/include/linux/hdsmart.h > > > +++ b/include/linux/hdsmart.h > > > @@ -17,7 +17,7 @@ > > > #ifndef _LINUX_HDSMART_H > > > #define _LINUX_HDSMART_H > > > > > > -#ifndef __KERNEL > > > +#ifndef __KERNEL__ > > > #define OFFLINE_FULL_SCAN 0 > > > #define SHORT_SELF_TEST 1 > > > #define EXTEND_SELF_TEST 2 > > > @@ -121,6 +121,6 @@ typedef struct ata_smart_selftestlog_s { > > > unsigned char resevered[2]; > > > unsigned char chksum; > > > } __attribute__ ((packed)) ata_smart_selftestlog_t; > > > -#endif /* __KERNEL__ * > > > +#endif /* __KERNEL__ */ > > > > > > #endif /* _LINUX_HDSMART_H */ > > > > if that header file isn't used by any kernel code, why bother having a > > check for __KERNEL__ in the first place? it's being exported to > > userspace unchecked: > > > > include/linux/Kbuild:header-y += hdsmart.h > > > > so why not just toss that check entirely? otherwise, you're going to > > get a header file exported to userspace that has a superfluous > > __KERNEL__ test in it. > > We don't want new (accidental etc.) kernel users of this header. >... Why can't we simply remove it? cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/