Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753742AbYBQTfT (ORCPT ); Sun, 17 Feb 2008 14:35:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751847AbYBQTfH (ORCPT ); Sun, 17 Feb 2008 14:35:07 -0500 Received: from pasmtpb.tele.dk ([80.160.77.98]:49390 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751702AbYBQTfF (ORCPT ); Sun, 17 Feb 2008 14:35:05 -0500 Date: Sun, 17 Feb 2008 20:35:14 +0100 From: Sam Ravnborg To: Roland McGrath Cc: Rene Herman , Linux Kernel , linux-kbuild@vger.kernel.org Subject: Re: 2.6.25-rc2 vdso_install breaks user "make install" Message-ID: <20080217193514.GJ14588@uranus.ravnborg.org> References: <47B6592A.6030200@keyaccess.nl> <20080216034211.8DD03270193@magilla.localdomain> <20080216113610.GB11362@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080216113610.GB11362@uranus.ravnborg.org> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1470 Lines: 36 On Sat, Feb 16, 2008 at 12:36:10PM +0100, Sam Ravnborg wrote: > On Fri, Feb 15, 2008 at 07:42:11PM -0800, Roland McGrath wrote: > > Perhaps it makes more sense to have vdso_install be a dependency of > > modules_install rather than install, since they both put things in /lib/modules. > > The installed vdso images are potentially useful for a kernel when you > > aren't bothering to build or install any modules, but those images are only > > ever useful for sophisticated debugging uses anyway. > > > > Sam, any thoughts? (See arch/x86/Makefile and arch/powerpc/Makefile.) > > Installing the vdso files as aprt of modules_install would be > unintuitive as this has nothing to do with modules. > > And since you wrote: > > useful for sophisticated debugging uses anyway > I suggest to make the vdso_install step independent as > in following patch. > [Note: help docs needs to mention the new target]. > > This solves the issue at ahnd and still gives us the posibility > to install the files should they be needed. Roland - if you agree will you please submit the patch to the x86 people. You can tag it: Signed-off-by: Sam Ravnborg or Acked-by: Sam Ravnborg as you like. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/