Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758459AbYBRDNT (ORCPT ); Sun, 17 Feb 2008 22:13:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753420AbYBRDNF (ORCPT ); Sun, 17 Feb 2008 22:13:05 -0500 Received: from 136-022.dsl.labridge.com ([206.117.136.22]:1788 "EHLO mail.perches.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1756806AbYBRDNE (ORCPT ); Sun, 17 Feb 2008 22:13:04 -0500 Subject: Re: [PATCH] x86: Coding style fixes for arch/x86/kernel/cpu/centaur.c From: Joe Perches To: Ingo Molnar Cc: Paolo Ciarrocchi , Linux Kernel , "tglx@linutronix.de" , "H. Peter Anvin" In-Reply-To: <20080218025645.GB30201@elte.hu> References: <20080217233023.26764dc9@paolo-desktop> <20080218025645.GB30201@elte.hu> Content-Type: text/plain Date: Sun, 17 Feb 2008 19:12:24 -0800 Message-Id: <1203304344.7181.45.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0-2mdv2008.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1402 Lines: 37 On Mon, 2008-02-18 at 03:56 +0100, Ingo Molnar wrote: > arch/x86/kernel/cpu/centaur.c | 394 +++++++++++++++++++++--------------------- > 1 file changed, 199 insertions(+), 195 deletions(-) > > Index: linux-x86.q/arch/x86/kernel/cpu/centaur.c > =================================================================== > --- linux-x86.q.orig/arch/x86/kernel/cpu/centaur.c > +++ linux-x86.q/arch/x86/kernel/cpu/centaur.c > @@ -52,13 +54,12 @@ static u32 __cpuinit ramtop(void) /* 16 > if (e820.map[i].addr > 0xFFFFFFFFUL) > continue; > /* > - * Don't MCR over reserved space. Ignore the ISA hole > - * we frob around that catastrophe already > + * Don't MCR over reserved space. Ignore the ISA hole > + * we frob around that catastrophe already > */ > - > - if (e820.map[i].type == E820_RESERVED) > - { > - if (e820.map[i].addr >= 0x100000UL && e820.map[i].addr < clip) > + if (e820.map[i].type == E820_RESERVED) { > + if (e820.map[i].addr >= 0x100000UL && > + e820.map[i].addr < clip) > clip = e820.map[i].addr; Doesn't this look better as: + if (e820.map[i].addr >= 0x100000UL && + e820.map[i].addr < clip) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/