Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755701AbYBRGnn (ORCPT ); Mon, 18 Feb 2008 01:43:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752614AbYBRGnf (ORCPT ); Mon, 18 Feb 2008 01:43:35 -0500 Received: from ns2.suse.de ([195.135.220.15]:51739 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752045AbYBRGne (ORCPT ); Mon, 18 Feb 2008 01:43:34 -0500 Date: Mon, 18 Feb 2008 07:43:32 +0100 Message-ID: From: Takashi Iwai To: Sam Ravnborg Cc: LKML , Andrew Morton , Jaroslav Kysela Subject: Re: [PATCH 27/27] [ALSA] hdsp - fix section mismatch warnings In-Reply-To: <1203250984-11285-27-git-send-email-sam@ravnborg.org> References: <20080217121255.GA10519@uranus.ravnborg.org> <1203250984-11285-27-git-send-email-sam@ravnborg.org> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2439 Lines: 65 At Sun, 17 Feb 2008 13:23:04 +0100, Sam Ravnborg wrote: > > Fix following warnings: > WARNING: sound/pci/rme9652/snd-hdsp.o(.text+0x34bc): Section mismatch in reference from the function hdsp_check_for_firmware() to the function .devinit.text:hdsp_request_fw_loader() > WARNING: sound/pci/rme9652/snd-hdsp.o(.text+0x4ac6): Section mismatch in reference from the function snd_hdsp_proc_read() to the function .devinit.text:hdsp_request_fw_loader() > > Calling hdsp_request_fw_loader() were triggered from /proc > so this is not restricted to init or hotplug. > So removing the __devexit annotation of this function > and one of the functions fix the warning. Thanks. The exactly same fix has been already on ALSA tree since weeks ago, but was never pushed... Takashi > > Signed-off-by: Sam Ravnborg > Cc: Takashi Iwai > Cc: Jaroslav Kysela > --- > sound/pci/rme9652/hdsp.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c > index c2bd438..6f07a25 100644 > --- a/sound/pci/rme9652/hdsp.c > +++ b/sound/pci/rme9652/hdsp.c > @@ -745,7 +745,7 @@ static int hdsp_get_iobox_version (struct hdsp *hdsp) > > > #ifdef HDSP_FW_LOADER > -static int __devinit hdsp_request_fw_loader(struct hdsp *hdsp); > +static int hdsp_request_fw_loader(struct hdsp *hdsp); > #endif > > static int hdsp_check_for_firmware (struct hdsp *hdsp, int load_on_demand) > @@ -4688,7 +4688,7 @@ static struct snd_pcm_ops snd_hdsp_capture_ops = { > .copy = snd_hdsp_capture_copy, > }; > > -static int __devinit snd_hdsp_create_hwdep(struct snd_card *card, > +static int snd_hdsp_create_hwdep(struct snd_card *card, > struct hdsp *hdsp) > { > struct snd_hwdep *hw; > @@ -4857,7 +4857,7 @@ static int snd_hdsp_create_alsa_devices(struct snd_card *card, struct hdsp *hdsp > > #ifdef HDSP_FW_LOADER > /* load firmware via hotplug fw loader */ > -static int __devinit hdsp_request_fw_loader(struct hdsp *hdsp) > +static int hdsp_request_fw_loader(struct hdsp *hdsp) > { > const char *fwfile; > const struct firmware *fw; > -- > 1.5.4.rc3.14.g44397 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/