Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754975AbYBRGsS (ORCPT ); Mon, 18 Feb 2008 01:48:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752217AbYBRGsG (ORCPT ); Mon, 18 Feb 2008 01:48:06 -0500 Received: from cantor.suse.de ([195.135.220.2]:50304 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751641AbYBRGsF (ORCPT ); Mon, 18 Feb 2008 01:48:05 -0500 Date: Mon, 18 Feb 2008 07:48:03 +0100 Message-ID: From: Takashi Iwai To: Chuck Ebbert Cc: Adel Gadllah , kernel list Subject: Re: [PATCH] snd-hda-intel: don't print using snd_printdd on device open In-Reply-To: <47B8F020.7030300@redhat.com> References: <47B80CED.3060903@gmail.com> <47B8F020.7030300@redhat.com> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1385 Lines: 36 At Sun, 17 Feb 2008 21:40:32 -0500, Chuck Ebbert wrote: > > From: Adel Gadllah > > snd-hda-intel: don't print using snd_printdd on device open > > When CONFIG_SND_DEBUG_DETECT is set the hda-intel driver prints verbose > info like this: > > ALSA sound/pci/hda/hda_intel.c:1259: azx_pcm_prepare: bufsize=0x4400, > fragsize=0x1100, format=0x11 > ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7, > stream=0x5, channel=0, format=0x11 > ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3, > stream=0x5, channel=0, format=0x11 > ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3, > stream=0x0, channel=0, format=0x0 > ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7, > stream=0x0, channel=0, format=0x0 > ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3, > stream=0x0, channel=0, format=0x0 > > Don't print anything in functions that get called when the device gets > opened/prepared for output. Why? This debug option is explicitly for debugging purposes, and I see no reason why such behavior is prohibited. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/