Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S288768AbSAIEF4>; Tue, 8 Jan 2002 23:05:56 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S288769AbSAIEFq>; Tue, 8 Jan 2002 23:05:46 -0500
Received: from megaela.fe.dis.titech.ac.jp ([131.112.171.110]:59401 "HELO
	megaela.srvf.org") by vger.kernel.org with SMTP id <S288768AbSAIEFo>;
	Tue, 8 Jan 2002 23:05:44 -0500
Date: Wed, 09 Jan 2002 13:05:37 +0900
Message-ID: <w533d1gqicu.wl@megaela.fe.dis.titech.ac.jp>
From: GOTO Masanori <gotom@debian.or.jp>
To: dalecki@evision-ventures.com
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: PATCH 2.5.2-pre9 scsi cleanup
In-Reply-To: In your message of "Tue, 08 Jan 2002 10:29:48 +0100"
	<3C3ABC0C.7050408@evision-ventures.com>
In-Reply-To: <Pine.LNX.4.33.0201011402560.13397-100000@penguin.transmeta.com>
	<3C3ABC0C.7050408@evision-ventures.com>
User-Agent: Wanderlust/2.2.15 (More Than Words) EMIKO/1.13.9 (Euglena tripteris) FLIM/1.13.2 (Kasanui) APEL/10.2 MULE XEmacs/21.1 (patch 10) (Capitol Reef) (i386-debian-linux)
MIME-Version: 1.0 (generated by EMIKO 1.13.9 - "Euglena tripteris")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Tue, 08 Jan 2002 10:29:48 +0100,
Martin Dalecki <dalecki@evision-ventures.com> wrote:
> The attached patch does the following.
> 
> 1. Clean up some ifdef confusion in do_mount
> 
> 2. Clean up the scsi code to make ppa.c work.
> 
> 3. Clean up some unneccessary unneeded globals from scsi code.

I don't understand why below removal are needed.
Do you think to replace with function like scsi_device_types()?

> -const char *const scsi_device_types[MAX_SCSI_DEVICE_CODE] =
> -{
> -	"Direct-Access    ",
> -	"Sequential-Access",
> -	"Printer          ",
> -	"Processor        ",
> -	"WORM             ",
> -	"CD-ROM           ",
> -	"Scanner          ",
> -	"Optical Device   ",
> -	"Medium Changer   ",
> -	"Communications   ",
> -	"Unknown          ",
> -	"Unknown          ",
> -	"Unknown          ",
> -	"Enclosure        ",
> -};
> -
> -/* 

-- gotom
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/