Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761040AbYBRTzm (ORCPT ); Mon, 18 Feb 2008 14:55:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760780AbYBRTzW (ORCPT ); Mon, 18 Feb 2008 14:55:22 -0500 Received: from fk-out-0910.google.com ([209.85.128.184]:11625 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760690AbYBRTzU (ORCPT ); Mon, 18 Feb 2008 14:55:20 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:from; b=oyGti3MqY2tSDc9h7jmW57crPX2noqyEhdf7KvM7cd9F5EtgY0vDV+u/OLBZpciPJW65jsYQPWlcWcD3ODmrojTuhi3D3vLc4noGbEnlCyveTVBy99d5bp0fMIdhNSGi7NVGiBRlnr8VxN+mucLvTnWrKpKFBuFB+GmEeF7k40k= Message-ID: <47B9E2A1.6090200@gmail.com> Date: Mon, 18 Feb 2008 20:55:13 +0100 User-Agent: Mozilla-Thunderbird 2.0.0.9 (X11/20080110) MIME-Version: 1.0 To: Kiyoshi Ueda CC: schwab@suse.de, bzolnier@gmail.com, linux-kernel@vger.kernel.org, jens.axboe@oracle.com, petkovbb@gmail.com, j-nomura@ce.jp.nec.com Subject: Re: 2.6.25-rc1/2 CD/DVD burning broken References: <58cb370e0802180759h4d44b9bci86f02919a48c7979@mail.gmail.com> <20080218.135827.74754725.k-ueda@ct.jp.nec.com> In-Reply-To: <20080218.135827.74754725.k-ueda@ct.jp.nec.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit From: Laura Garcia Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2107 Lines: 62 It works great for me. Thanks, Laura. Kiyoshi Ueda wrote: > Hi Andreas, > > On Sat, 16 Feb 2008 21:52:21 +0100, Andreas Schwab wrote: >> Since commit aaa04c28cb9a1efd42541fdb7ab648231c2a2263 [blk_end_request: >> changing ide-cd (take 4)] I cannot burn any CD/DVD any more, getting the >> following error from wodim: >> >> Errno: 0 (Success), write_g1 scsi sendcmd: no error >> CDB: 2A 00 00 00 00 00 00 00 1F 00 >> status: 0x2 (CHECK CONDITION) >> Sense Bytes: 70 00 05 00 00 00 00 0E 00 00 00 00 21 02 00 00 >> Sense Key: 0x5 Illegal Request, Segment 0 >> Sense Code: 0x21 Qual 0x02 (invalid address for write) Fru 0x0 >> Sense flags: Blk 0 (not valid) >> resid: 63488 > > Could you try this patch? > I've only done a compile test, so this patch may not work. > > During the conversion to blk_end_request, the code was changed > *not* to set rq->data_len = 0. > I removed that part because I thought it was just a trigger to > call post_transform_command(). However, since data_len can be > used as a residual length of the transfer, it might have to remain > there. > Actually, wodim seems checking the residual count how far it wrote > (e.g. wodim/wodim.c:write_track_data()). > > This patch brings back the rq->data_len = 0. > > --- 2.6.25-rc2/drivers/ide/ide-cd.c 2008-02-15 15:57:20.000000000 -0500 > +++ ide-fix/drivers/ide/ide-cd.c 2008-02-18 01:23:40.000000000 -0500 > @@ -1207,9 +1207,13 @@ static ide_startstop_t cdrom_newpc_intr( > end_request: > if (blk_pc_request(rq)) { > unsigned long flags; > + unsigned int dlen = rq->data_len; > + > + if (dma) > + rq->data_len = 0; > > spin_lock_irqsave(&ide_lock, flags); > - if (__blk_end_request(rq, 0, rq->data_len)) > + if (__blk_end_request(rq, 0, dlen)) > BUG(); > HWGROUP(drive)->rq = NULL; > spin_unlock_irqrestore(&ide_lock, flags); > > Thanks, > Kiyoshi Ueda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/