From: Neil Brown <neilb@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Date: Tue, 19 Feb 2008 08:45:03 +1100
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <18361.64607.812442.423082@notabene.brown>
Cc: Adrian Bunk <bunk@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fs/drop_caches.c: make 2 functions static
In-Reply-To: message from Andrew Morton on Monday February 18
References: <20080217081746.GI3848@cs181133002.pp.htv.fi>
	<20080218050147.17f5ee0b.akpm@linux-foundation.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1100
Lines: 31

On Monday February 18, akpm@linux-foundation.org wrote:
> On Sun, 17 Feb 2008 10:17:46 +0200 Adrian Bunk <bunk@kernel.org> wrote:
> 
> > This patch makes the following needlessly global functions static:
> > - drop_pagecache()
> > - drop_slab()
> > 
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
..
> 
> This was originally done because Neil said that he planned to use these in
> nfsd.  I guess that didn't happen, and an additional patch would be needed
> here anyway to do the module exports.  So....  zap.

Did I?  I wonder why.  Neither my memory or my mail archive gives me
any hints, so I suspect it must have just been a passing fancy that
resolved into a really dumb idea (as so many passing fancies do).

Zap-supported-by: NeilBrown <neilb@suse.de>

Hmmm... I guess that should really be

  Acked-By: NeilBrown <neilb@suse.de>
;-)

NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/