Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755225AbYBSPxV (ORCPT ); Tue, 19 Feb 2008 10:53:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751049AbYBSPxM (ORCPT ); Tue, 19 Feb 2008 10:53:12 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:54349 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbYBSPxM (ORCPT ); Tue, 19 Feb 2008 10:53:12 -0500 Date: Tue, 19 Feb 2008 16:52:52 +0100 From: Ingo Molnar To: "Ahmed S. Darwish" Cc: Andrew Morton , Ingo Molnar , LKML Subject: Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code Message-ID: <20080219155252.GA27280@elte.hu> References: <20080219153720.GA2967@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080219153720.GA2967@ubuntu> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 23 * Ahmed S. Darwish wrote: > - local_irq_disable(); > - t->next = __get_cpu_var(tasklet_vec).list; > - __get_cpu_var(tasklet_vec).list = t; > - __raise_softirq_irqoff(TASKLET_SOFTIRQ); > - local_irq_enable(); > + /* We were not lucky enough to run, reschedule. */ > + __tasklet_schedule(t); i think there's a subtle difference that you missed: this one does __raise_softirq_irqoff(), while __tasklet_schedule() does a raise_softirq_irqoff(). (note the lack of undescores) the reason is to avoid infinitely self-activating tasklets. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/