Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755387AbYBSTbP (ORCPT ); Tue, 19 Feb 2008 14:31:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760628AbYBST37 (ORCPT ); Tue, 19 Feb 2008 14:29:59 -0500 Received: from smtp6.pp.htv.fi ([213.243.153.40]:36968 "EHLO smtp6.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756175AbYBST36 (ORCPT ); Tue, 19 Feb 2008 14:29:58 -0500 Date: Tue, 19 Feb 2008 21:29:22 +0200 From: Adrian Bunk To: David Somayajulu , James Bottomley Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code Message-ID: <20080219192922.GH31955@cs181133002.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1714 Lines: 57 This patch removes dead code spotted by the Coverity checker. Signed-off-by: Adrian Bunk --- drivers/scsi/qla4xxx/ql4_isr.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) --- linux-2.6/drivers/scsi/qla4xxx/ql4_isr.c.old 2008-02-19 20:29:16.000000000 +0200 +++ linux-2.6/drivers/scsi/qla4xxx/ql4_isr.c 2008-02-19 20:30:37.000000000 +0200 @@ -91,38 +91,22 @@ static void qla4xxx_status_entry(struct if (scsi_status == 0) { cmd->result = DID_OK << 16; break; } if (sts_entry->iscsiFlags & ISCSI_FLAG_RESIDUAL_OVER) { cmd->result = DID_ERROR << 16; break; } - if (sts_entry->iscsiFlags &ISCSI_FLAG_RESIDUAL_UNDER) { + if (sts_entry->iscsiFlags &ISCSI_FLAG_RESIDUAL_UNDER) scsi_set_resid(cmd, residual); - if (!scsi_status && ((scsi_bufflen(cmd) - residual) < - cmd->underflow)) { - - cmd->result = DID_ERROR << 16; - - DEBUG2(printk("scsi%ld:%d:%d:%d: %s: " - "Mid-layer Data underrun0, " - "xferlen = 0x%x, " - "residual = 0x%x\n", ha->host_no, - cmd->device->channel, - cmd->device->id, - cmd->device->lun, __func__, - scsi_bufflen(cmd), residual)); - break; - } - } cmd->result = DID_OK << 16 | scsi_status; if (scsi_status != SCSI_CHECK_CONDITION) break; /* Copy Sense Data into sense buffer. */ memset(cmd->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE); sensebytecnt = le16_to_cpu(sts_entry->senseDataByteCnt); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/