Date: Tue, 19 Feb 2008 21:29:24 +0200
From: Adrian Bunk <bunk@kernel.org>
To: David Sterba <dsterba@suse.cz>, jkosina@suse.cz
Cc: Jiri Slaby <jslaby@suse.cz>, linux-kernel@vger.kernel.org
Subject: ipwireless_network_packet_received(): inconsequent NULL checking
Message-ID: <20080219192924.GI31955@cs181133002.pp.htv.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1675
Lines: 46

The Coverity checker spotted the following inconsequent NULL checking in 
drivers/char/pcmcia/ipwireless/network.c:

<--  snip  -->

void ipwireless_network_packet_received(struct ipw_network *network,
                                        unsigned int channel_idx,
                                        unsigned char *data,
                                        unsigned int length)
{
...
                /*
                 * If it's associated with a tty (other than the RAS channel
                 * when we're online), then send the data to that tty. The RAS
                 * channel's data is handled above - it always goes through
                 * ppp_generic.
                 */
                if (tty && channel_idx == IPW_CHANNEL_RAS
                                && (network->ras_control_lines &
                                        IPW_CONTROL_LINE_DCD) != 0
                                && ipwireless_tty_is_modem(tty)) {
...
                /* Otherwise we send it out the tty. */
                else
                        ipwireless_tty_received(tty, data, length);
...

<--  snip  -->

ipwireless_tty_received() dereferences "tty".

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/