Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763935AbYBTAPr (ORCPT ); Tue, 19 Feb 2008 19:15:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759057AbYBTAOc (ORCPT ); Tue, 19 Feb 2008 19:14:32 -0500 Received: from smtp4.pp.htv.fi ([213.243.153.38]:36211 "EHLO smtp4.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758742AbYBTAOa (ORCPT ); Tue, 19 Feb 2008 19:14:30 -0500 Date: Wed, 20 Feb 2008 02:13:53 +0200 From: Adrian Bunk To: jgarzik@pobox.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [2.6 patch] net/phy/mdio_bus.c: fix a check-after-use Message-ID: <20080220001353.GV31955@cs181133002.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 877 Lines: 31 This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk --- 6beeb3ac577d74d72b2f91bd654eecb904c3c17e diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 6e9f619..963630c 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -49,13 +49,13 @@ int mdiobus_register(struct mii_bus *bus) int i; int err = 0; - mutex_init(&bus->mdio_lock); - if (NULL == bus || NULL == bus->name || NULL == bus->read || NULL == bus->write) return -EINVAL; + mutex_init(&bus->mdio_lock); + if (bus->reset) bus->reset(bus); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/