Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764102AbYBTAQb (ORCPT ); Tue, 19 Feb 2008 19:16:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762397AbYBTAOn (ORCPT ); Tue, 19 Feb 2008 19:14:43 -0500 Received: from smtp5.pp.htv.fi ([213.243.153.39]:41114 "EHLO smtp5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761989AbYBTAOl (ORCPT ); Tue, 19 Feb 2008 19:14:41 -0500 Date: Wed, 20 Feb 2008 02:14:04 +0200 From: Adrian Bunk To: Zhang Rui , Thomas Sujith , Len Brown Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [2.6 patch] drivers/thermal/thermal.c: fix a check-after-use Message-ID: <20080220001404.GW31955@cs181133002.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 949 Lines: 28 This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk --- 570462ca4441d8d63dfd46efe6e5b2b1c251a611 diff --git a/drivers/thermal/thermal.c b/drivers/thermal/thermal.c index e782b3e..958654b 100644 --- a/drivers/thermal/thermal.c +++ b/drivers/thermal/thermal.c @@ -308,10 +308,10 @@ int thermal_zone_bind_cooling_device(struct thermal_zone_device *tz, struct thermal_cooling_device_instance *pos; int result; - if (trip >= tz->trips || (trip < 0 && trip != THERMAL_TRIPS_NONE)) + if (!tz || !cdev) return -EINVAL; - if (!tz || !cdev) + if (trip >= tz->trips || (trip < 0 && trip != THERMAL_TRIPS_NONE)) return -EINVAL; dev = -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/