Date: Tue, 19 Feb 2008 16:29:14 -0800 (PST)
Message-Id: <20080219.162914.197514826.davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: bunk@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC: 2.6.25 patch] ipv4/fib_hash.c: fix NULL dereference
From: David Miller <davem@davemloft.net>
In-Reply-To: <47BB60E6.6030506@cosmosbay.com>
References: <20080219224951.GP31955@cs181133002.pp.htv.fi>
	<47BB60E6.6030506@cosmosbay.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 773
Lines: 20

From: Eric Dumazet <dada1@cosmosbay.com>
Date: Wed, 20 Feb 2008 00:06:14 +0100

> Adrian Bunk a ?crit :
> > Unless I miss a guaranteed relation between between "f" and 
> > "new_fa->fa_info" this patch is required for fixing a NULL dereference
> > introduced by commit a6501e080c318f8d4467679d17807f42b3a33cd5 and 
> > spotted by the Coverity checker.
> > 
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
 ...
> Hum, you are right, kmem_cache_free() doesnt allow a NULL object, like kfree() 
> does.

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/