Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763636AbYBTBDX (ORCPT ); Tue, 19 Feb 2008 20:03:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755957AbYBTBDN (ORCPT ); Tue, 19 Feb 2008 20:03:13 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:52408 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755755AbYBTBDL (ORCPT ); Tue, 19 Feb 2008 20:03:11 -0500 From: "Rafael J. Wysocki" To: Greg KH Subject: [PATCH] PM: Remove unbalanced mutex_unlock() from dpm_resume() Date: Wed, 20 Feb 2008 02:01:41 +0100 User-Agent: KMail/1.9.6 (enterprise 20070904.708012) Cc: ACPI Devel Maling List , Alan Stern , Len Brown , "Linux-pm mailing list" , LKML , Pavel Machek MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802200201.42543.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1052 Lines: 35 Hi Greg, Please consider taking the following fix for 2.6.25. Thanks, Rafael --- From: Rafael J. Wysocki Remove an unnecessary unlocking of dpm_list_mtx in the error path in drivers/base/power/main.c:dpm_suspend() . Signed-off-by: Rafael J. Wysocki --- drivers/base/power/main.c | 1 - 1 file changed, 1 deletion(-) Index: linux-2.6/drivers/base/power/main.c =================================================================== --- linux-2.6.orig/drivers/base/power/main.c +++ linux-2.6/drivers/base/power/main.c @@ -479,7 +479,6 @@ static int dpm_suspend(pm_message_t stat mutex_lock(&dpm_list_mtx); if (list_empty(&dev->power.entry)) list_add(&dev->power.entry, &dpm_locked); - mutex_unlock(&dpm_list_mtx); break; } mutex_lock(&dpm_list_mtx); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/