Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763261AbYBTCN4 (ORCPT ); Tue, 19 Feb 2008 21:13:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756638AbYBTCNr (ORCPT ); Tue, 19 Feb 2008 21:13:47 -0500 Received: from accolon.hansenpartnership.com ([76.243.235.52]:33092 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755041AbYBTCNq (ORCPT ); Tue, 19 Feb 2008 21:13:46 -0500 Subject: Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code From: James Bottomley To: Adrian Bunk Cc: David Somayajulu , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org In-Reply-To: <20080219192922.GH31955@cs181133002.pp.htv.fi> References: <20080219192922.GH31955@cs181133002.pp.htv.fi> Content-Type: text/plain Date: Tue, 19 Feb 2008 20:13:38 -0600 Message-Id: <1203473618.3103.37.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1740 Lines: 55 On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > This patch removes dead code spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk > > --- > > drivers/scsi/qla4xxx/ql4_isr.c | 18 +----------------- > 1 file changed, 1 insertion(+), 17 deletions(-) > > --- linux-2.6/drivers/scsi/qla4xxx/ql4_isr.c.old 2008-02-19 20:29:16.000000000 +0200 > +++ linux-2.6/drivers/scsi/qla4xxx/ql4_isr.c 2008-02-19 20:30:37.000000000 +0200 > @@ -91,38 +91,22 @@ static void qla4xxx_status_entry(struct > if (scsi_status == 0) { > cmd->result = DID_OK << 16; > break; > } > > if (sts_entry->iscsiFlags & ISCSI_FLAG_RESIDUAL_OVER) { > cmd->result = DID_ERROR << 16; > break; > } > > - if (sts_entry->iscsiFlags &ISCSI_FLAG_RESIDUAL_UNDER) { > + if (sts_entry->iscsiFlags &ISCSI_FLAG_RESIDUAL_UNDER) > scsi_set_resid(cmd, residual); > - if (!scsi_status && ((scsi_bufflen(cmd) - residual) < > - cmd->underflow)) { > - > - cmd->result = DID_ERROR << 16; > - > - DEBUG2(printk("scsi%ld:%d:%d:%d: %s: " > - "Mid-layer Data underrun0, " > - "xferlen = 0x%x, " > - "residual = 0x%x\n", ha->host_no, > - cmd->device->channel, > - cmd->device->id, > - cmd->device->lun, __func__, > - scsi_bufflen(cmd), residual)); > - break; > - } > - } This code doesn't look dead to me, it looks to be enforcing cmd->underrun if set ... what makes the coverity checker think it can never be executed? James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/