Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753498AbYBTMSd (ORCPT ); Wed, 20 Feb 2008 07:18:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751338AbYBTMSX (ORCPT ); Wed, 20 Feb 2008 07:18:23 -0500 Received: from rtsoft3.corbina.net ([85.21.88.6]:33665 "EHLO buildserver.ru.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751195AbYBTMSW (ORCPT ); Wed, 20 Feb 2008 07:18:22 -0500 Date: Wed, 20 Feb 2008 15:18:18 +0300 From: Anton Vorontsov To: Paul Mackerras Cc: Andrew Morton , Clemens Koller , benh@kernel.crashing.org, linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com, Krzysztof Helt , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Geert Uytterhoeven Subject: Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness Message-ID: <20080220121818.GA20836@localhost.localdomain> Reply-To: avorontsov@ru.mvista.com References: <20080214224942.a0cb6218.akpm@linux-foundation.org> <20080215164542.GB16810@localhost.localdomain> <20080218081847.e9e65f2f.krzysztof.h1@poczta.fm> <19805.1203355811@turing-police.cc.vt.edu> <47BA162C.5000807@anagramm.de> <1203381353.6740.59.camel@pasglop> <47BABD3A.7010102@anagramm.de> <20080219040530.7b1d115d.akpm@linux-foundation.org> <18363.31427.989835.105966@cargo.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Disposition: inline In-Reply-To: <18363.31427.989835.105966@cargo.ozlabs.ibm.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1386 Lines: 39 On Wed, Feb 20, 2008 at 11:56:35AM +1100, Paul Mackerras wrote: > Andrew Morton writes: > > > Bizarrely, the original author of the patch (Anton) has fallen off the cc. > > Could whoever did that please thwap himself? > > > > Anyway, my head is now officially spinning. Did anyone actually have a > > reason why we shouldn't proceed with Anton's patch? > > I was wondering if it would be sufficient to provide alternative > versions of fb_readl, fb_writel etc. that do byte-swapping. This is of course viable alternative. And I was considering this, but later I abandoned the idea: that way we'll end up doing math in the native endianness and then converting it to the foreign. This feels ugly in contrast when we can do the right math in the first place, per framebuffer. > That > would mean that all framebuffers would have to have the same > endianness, Yup, another downside of changing the code to fix some narrow problem. Plus, this means things will break if/when we'll attach PCI video card into the MPC8360E-RDK. Thanks, -- Anton Vorontsov email: cbou@mail.ru backup email: ya-cbou@yandex.ru irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/