Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933646AbYBTQbo (ORCPT ); Wed, 20 Feb 2008 11:31:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932326AbYBTQNm (ORCPT ); Wed, 20 Feb 2008 11:13:42 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:46530 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932302AbYBTQNk (ORCPT ); Wed, 20 Feb 2008 11:13:40 -0500 Date: Wed, 20 Feb 2008 11:13:39 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: "Rafael J. Wysocki" cc: Greg KH , ACPI Devel Maling List , Len Brown , Linux-pm mailing list , LKML , Pavel Machek Subject: Re: [PATCH] PM: Remove unbalanced mutex_unlock() from dpm_resume() In-Reply-To: <200802200201.42543.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1260 Lines: 42 On Wed, 20 Feb 2008, Rafael J. Wysocki wrote: > Hi Greg, > > Please consider taking the following fix for 2.6.25. Don't just consider it! :-) It's a real bug fix. > Thanks, > Rafael > > --- > From: Rafael J. Wysocki > > Remove an unnecessary unlocking of dpm_list_mtx in the error path > in drivers/base/power/main.c:dpm_suspend() . > > Signed-off-by: Rafael J. Wysocki > --- > drivers/base/power/main.c | 1 - > 1 file changed, 1 deletion(-) > > Index: linux-2.6/drivers/base/power/main.c > =================================================================== > --- linux-2.6.orig/drivers/base/power/main.c > +++ linux-2.6/drivers/base/power/main.c > @@ -479,7 +479,6 @@ static int dpm_suspend(pm_message_t stat > mutex_lock(&dpm_list_mtx); > if (list_empty(&dev->power.entry)) > list_add(&dev->power.entry, &dpm_locked); > - mutex_unlock(&dpm_list_mtx); > break; > } > mutex_lock(&dpm_list_mtx); Acked-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/