Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934506AbYBTUvz (ORCPT ); Wed, 20 Feb 2008 15:51:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759666AbYBTUvo (ORCPT ); Wed, 20 Feb 2008 15:51:44 -0500 Received: from gateway.drzeus.cx ([85.8.24.16]:45038 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754044AbYBTUvn (ORCPT ); Wed, 20 Feb 2008 15:51:43 -0500 Date: Wed, 20 Feb 2008 21:51:27 +0100 From: Pierre Ossman To: Alan Stern Cc: "Rafael J. Wysocki" , Zdenek Kabelac , Kernel development list Subject: Re: [Bug 10030] Suspend doesn't work when SD card is inserted Message-ID: <20080220215127.58b8ec70@mjolnir.drzeus.cx> In-Reply-To: References: <20080220183041.46c16ef0@mjolnir.drzeus.cx> X-Mailer: Claws Mail 3.3.0 (GTK+ 2.12.8; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1423 Lines: 33 On Wed, 20 Feb 2008 14:26:16 -0500 (EST) Alan Stern wrote: > > Do I understand this correctly? You've got special handling for the > case where a bus handler doesn't have a resume routine, but no special > handling for the case where it doesn't have a suspend routine? Hmm... There should be checks for both, but the code seems to suggest otherwise. > Why bother to remove the device if neither routine exists (there won't be > any need to revive it since the bus never got suspended)? The bus always gets suspended. The checks are to determine if state is saved or not. If it isn't, then a suspend/resume is treated as a removal/insertion. > And why not simply fail the suspend if the resume routine doesn't exist > and the suspend routine does? Maybe with an error message in the > system log. For the asymmetric case, I guess that would do. But I still want to remove devices when the bus handler has no suspend handling. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/