Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934246AbYBTXEi (ORCPT ); Wed, 20 Feb 2008 18:04:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755685AbYBTXEI (ORCPT ); Wed, 20 Feb 2008 18:04:08 -0500 Received: from host64.cybernetics.com ([70.169.137.4]:3719 "EHLO mail.cybernetics.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753232AbYBTXEG (ORCPT ); Wed, 20 Feb 2008 18:04:06 -0500 Message-ID: <47BCB1E9.8020102@cybernetics.com> Date: Wed, 20 Feb 2008 18:04:09 -0500 From: Tony Battersby User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: Matt Carlson Cc: Michael Chan , David Miller , herbert@gondor.apana.org.au, netdev , gregkh@suse.de, linux-kernel@vger.kernel.org Subject: Re: TG3 network data corruption regression 2.6.24/2.6.23.4 References: <47BA0984.2070306@cybernetics.com> <1203381120.13495.78.camel@dell> <20080218.163554.74130592.davem@davemloft.net> <1203383046.13495.87.camel@dell> <47BB00EC.3010607@cybernetics.com> <1203448265.13495.95.camel@dell> <47BB54C2.6090501@cybernetics.com> <20080220013824.GA5416@localdomain> In-Reply-To: <20080220013824.GA5416@localdomain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 31 The following patch fixes the problem for me. Do we want to accept this patch and call it a day or continue investigating the source of the problem? Patch applies to 2.6.24.2, but doesn't apply to 2.6.25-rc. If everyone agrees that this is the right solution, I will resubmit with a proper subject line and description. Tony --- linux-2.6.24.2/include/net/sock.h.orig 2008-02-20 17:19:20.000000000 -0500 +++ linux-2.6.24.2/include/net/sock.h 2008-02-20 17:25:55.000000000 -0500 @@ -1236,8 +1236,10 @@ static inline struct sk_buff *sk_stream_ { struct sk_buff *skb; - /* The TCP header must be at least 32-bit aligned. */ - size = ALIGN(size, 4); + /* The TCP header must be at least 32-bit aligned, but some chipsets + * such as Broadcom BCM5701 require at least 16-byte alignment. + */ + size = ALIGN(size, 16); skb = alloc_skb_fclone(size + sk->sk_prot->max_header, gfp); if (skb) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/