Date: Thu, 21 Feb 2008 07:04:27 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peter@programming.kicks-ass.net>,
       Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
       Dhaval Giani <dhaval@linux.vnet.ibm.com>, linux-kernel@vger.kernel.org
Subject: Re: Make yield_task_fair more efficient
Message-ID: <20080221060427.GA9159@elte.hu>
References: <20080221053321.GA26918@balbir.in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080221053321.GA26918@balbir.in.ibm.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 764
Lines: 18


* Balbir Singh <balbir@linux.vnet.ibm.com> wrote:

> __pick_last_entity() walks the entire tree on O(lgn) time to find the 
> rightmost entry. This patch makes the routine more efficient by 
> reducing the cost of the lookup

hm, i'm not sure we want to do this: we'd be slowing down the fastpath 
of all the other common scheduler functions, for the sake of a rarely 
used (and broken ...) API: yield. And note that an rbtree walk is not 
slow at all - if you are yielding frequently it's probably all cached.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/