Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932874AbYBUNfb (ORCPT ); Thu, 21 Feb 2008 08:35:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751311AbYBUNfT (ORCPT ); Thu, 21 Feb 2008 08:35:19 -0500 Received: from 75.neteffect.com ([204.57.75.75]:64072 "EHLO velma.neteffect.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751495AbYBUNfR (ORCPT ); Thu, 21 Feb 2008 08:35:17 -0500 Date: Thu, 21 Feb 2008 08:29:41 -0600 From: gstreiff@neteffect.com Message-Id: <200802211429.m1LETfLj005153@velma.neteffect.com> To: rdreier@cisco.com Subject: [PATCH 2.6 6/8] RDMA/nes: Fix rdma connection establishment on big-endian platforms Cc: flatif@neteffect.com, general@lists.openfabrics.org, linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2581 Lines: 71 From: Faisal Latif With commit ef19454bd437b2ba, behavior of crc32c changes on big-endian platforms. Our algorithm expects previous behavior otherwise we have rdma connection establishment failure on big-endian platforms like ppc64. Applying cpu_to_le32() to value returned by crc32c() to get previous behavior. Signed-off-by: Faisal Latif Signed-off-by: Glenn Streiff --- drivers/infiniband/hw/nes/nes.h | 14 ++++++++++++++ drivers/infiniband/hw/nes/nes_cm.c | 5 +++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes.h b/drivers/infiniband/hw/nes/nes.h index fd57e8a..b0d3c52 100644 --- a/drivers/infiniband/hw/nes/nes.h +++ b/drivers/infiniband/hw/nes/nes.h @@ -285,6 +285,20 @@ struct nes_device { }; +static inline u32 get_crc_value(struct nes_v4_quad* nes_quad) +{ + u32 crc_value; + crc_value = crc32c(~0, (void *)nes_quad, sizeof (struct nes_v4_quad)); + + /* + * With commit ef19454bd437b2ba, behavior of crc32c changes on + * big-endian platforms. Our algorithm expects previous behavior + * otherwise we have rdma connection establishment issue on ppc64. + */ + crc_value = cpu_to_le32(crc_value); + return crc_value; +} + static inline void set_wqe_64bit_value(__le32 *wqe_words, u32 index, u64 value) { diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c index 6c298aa..1f042d1 100644 --- a/drivers/infiniband/hw/nes/nes_cm.c +++ b/drivers/infiniband/hw/nes/nes_cm.c @@ -2320,6 +2320,7 @@ int nes_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) struct iw_cm_event cm_event; struct nes_hw_qp_wqe *wqe; struct nes_v4_quad nes_quad; + u32 crc_value; int ret; ibqp = nes_get_qp(cm_id->device, conn_param->qpn); @@ -2436,8 +2437,8 @@ int nes_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) nes_quad.TcpPorts[1] = cm_id->local_addr.sin_port; /* Produce hash key */ - nesqp->hte_index = cpu_to_be32( - crc32c(~0, (void *)&nes_quad, sizeof(nes_quad)) ^ 0xffffffff); + crc_value = get_crc_value(&nes_quad); + nesqp->hte_index = cpu_to_be32(crc_value ^ 0xffffffff); nes_debug(NES_DBG_CM, "HTE Index = 0x%08X, CRC = 0x%08X\n", nesqp->hte_index, nesqp->hte_index & adapter->hte_index_mask); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/