Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763648AbYBUP1r (ORCPT ); Thu, 21 Feb 2008 10:27:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754027AbYBUP1g (ORCPT ); Thu, 21 Feb 2008 10:27:36 -0500 Received: from g5t0007.atlanta.hp.com ([15.192.0.44]:6806 "EHLO g5t0007.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753775AbYBUP1f (ORCPT ); Thu, 21 Feb 2008 10:27:35 -0500 Message-ID: <47BD9872.9050308@hp.com> Date: Thu, 21 Feb 2008 10:27:46 -0500 From: Vlad Yasevich User-Agent: Thunderbird 2.0.0.4 (X11/20070604) MIME-Version: 1.0 To: =?ISO-8859-1?Q?Ilpo_J=E4rvinen?= Cc: Netdev , LKML , David Miller , Arnaldo Carvalho de Melo Subject: Re: [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf References: <1203515238-22848-1-git-send-email-ilpo.jarvinen@helsinki.fi> <1203515238-22848-2-git-send-email-ilpo.jarvinen@helsinki.fi> <1203515238-22848-3-git-send-email-ilpo.jarvinen@helsinki.fi> <1203515238-22848-4-git-send-email-ilpo.jarvinen@helsinki.fi> <1203515238-22848-5-git-send-email-ilpo.jarvinen@helsinki.fi> <1203515238-22848-6-git-send-email-ilpo.jarvinen@helsinki.fi> <1203515238-22848-7-git-send-email-ilpo.jarvinen@helsinki.fi> <1203515238-22848-8-git-send-email-ilpo.jarvinen@helsinki.fi> <47BCA6B8.5000904@hp.com> In-Reply-To: X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2092 Lines: 55 Ilpo J?rvinen wrote: > On Wed, 20 Feb 2008, Vlad Yasevich wrote: > >> Ilpo J?rvinen wrote: >>> I added inline to sctp_add_cmd and appropriate comment there to >>> avoid adding another call into the call chain. This works at least >>> with "gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)". Alternatively, >>> __sctp_add_cmd could be introduced to .h. >>> >> My only concern was performance regressions, but it looks like it >> doesn't effect anything from the few quick runs I've made. > > There was one call made anyway, it's a bit hard to see how it would hurt > to push that BUG() deeper down (in fact, this is one of the easiest case > in this respect, many other cases elsewhere that need uninlining don't > currently make any calls with inlines). > >> Since we are putting sctp_add_cmd_sf() on the call stack, we might >> as well get rid of sctp_add_cmd() and reduce it a bit more. > > IMHO it is definately better solution for archiving the size reduction, > I just didn't know before that the only sctp_add_cmd call could be > converted. That one was a really silly one. The chance of not calling BUG() in that one case was so small, that it didn't really make any sense from the code robustness side. > > [...snip...] >> diff --git a/net/sctp/command.c b/net/sctp/command.c >> index bb97733..3a06513 100644 >> --- a/net/sctp/command.c >> +++ b/net/sctp/command.c >> @@ -51,19 +51,16 @@ int sctp_init_cmd_seq(sctp_cmd_seq_t *seq) >> >> /* Add a command to a sctp_cmd_seq_t. >> * Return 0 if the command sequence is full. >> + * >> + * Inline here is not a mistake, this way sctp_add_cmd_sf doesn't need extra >> + * calls, size penalty is of insignificant magnitude here > > This won't be a necessary note anymore. :-) > > [...snip...] > Yeah. If you are going to resubmit, feel free to put my Signed-off-by line. -vlad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/