Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756098AbYBUTrB (ORCPT ); Thu, 21 Feb 2008 14:47:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763110AbYBUTqq (ORCPT ); Thu, 21 Feb 2008 14:46:46 -0500 Received: from mx38.mail.ru ([194.67.23.16]:64902 "EHLO mx38.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755237AbYBUTqp (ORCPT ); Thu, 21 Feb 2008 14:46:45 -0500 From: Andrey Borzenkov To: "Kok, Auke" Subject: Re: [2.6.25-rc2] e100: Trying to free already-free IRQ 11 during suspend ... Date: Thu, 21 Feb 2008 22:46:31 +0300 User-Agent: KMail/1.9.9 Cc: Andrew Morton , e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <200802171536.51695.arvidjaar@mail.ru> <47BC725C.3060400@intel.com> <47BDC3E7.8040807@intel.com> In-Reply-To: <47BDC3E7.8040807@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart9869805.M9Ff8evE17"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200802212246.32542.arvidjaar@mail.ru> X-Spam: Not detected X-Mras: OK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5521 Lines: 149 --nextPart9869805.M9Ff8evE17 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 21 February 2008, Kok, Auke wrote: > Kok, Auke wrote: > > Kok, Auke wrote: > >> Andrew Morton wrote: > >>> On Sun, 17 Feb 2008 15:36:50 +0300 Andrey Borzenkov wrote: > >>> > >>>> ... and possibly reboot/poweroff (it flows by too fast to be legible= ). > >>>> > >>>> [ 8803.850634] ACPI: Preparing to enter system sleep state S3 > >>>> [ 8803.853141] Suspending console(s) > >>>> [ 8805.287505] serial 00:09: disabled > >>>> [ 8805.291564] Trying to free already-free IRQ 11 > >>>> [ 8805.291579] Pid: 6920, comm: pm-suspend Not tainted 2.6.25-rc2-1a= vb #2 > >>>> [ 8805.291628] [] free_irq+0xb7/0x130 > >>>> [ 8805.291675] [] e100_suspend+0xc0/0x100 > >>>> [ 8805.291724] [] pci_device_suspend+0x26/0x70 > >>>> [ 8805.291747] [] suspend_device+0x94/0xd0 > >>>> [ 8805.291763] [] device_suspend+0x153/0x240 > >>>> [ 8805.291784] [] suspend_devices_and_enter+0x4f/0xf0 > >>>> [ 8805.291808] [] ? freeze_processes+0x3f/0x80 > >>>> [ 8805.291825] [] enter_state+0xaa/0x140 > >>>> [ 8805.291840] [] state_store+0x8f/0xd0 > >>>> [ 8805.291852] [] ? state_store+0x0/0xd0 > >>>> [ 8805.291866] [] kobj_attr_store+0x24/0x30 > >>>> [ 8805.291901] [] sysfs_write_file+0xbb/0x110 > >>>> [ 8805.291936] [] vfs_write+0x99/0x130 > >>>> [ 8805.291963] [] ? sysfs_write_file+0x0/0x110 > >>>> [ 8805.291979] [] sys_write+0x3d/0x70 > >>>> [ 8805.291998] [] sysenter_past_esp+0x5f/0xa5 > >>>> [ 8805.292038] =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > >>>> [ 8805.347640] ACPI: PCI interrupt for device 0000:00:06.0 disabled > >>>> [ 8805.361128] ACPI: PCI interrupt for device 0000:00:02.0 disabled > >>>> [ 8805.376670] hwsleep-0322 [00] enter_sleep_state : Entering s= leep state [S3] > >>>> [ 8805.376670] Back to C! > >>>> > >>>> Interface is unused normally (only for netconsole sometimes). dmesg = and config > >>>> attached. > >>> Does reverting this: > >>> > >>> commit 8543da6672b0994921f014f2250e27ae81645580 > >>> Author: Auke Kok > >>> Date: Wed Dec 12 16:30:42 2007 -0800 > >>> > >>> e100: free IRQ to remove warningwhenrebooting > >>> =20 > >>> with this patch: > >>> > >>> --- a/drivers/net/e100.c~revert-1 > >>> +++ a/drivers/net/e100.c > >>> @@ -2804,9 +2804,8 @@ static int e100_suspend(struct pci_dev * > >>> pci_enable_wake(pdev, PCI_D3cold, 0); > >>> } > >>> =20 > >>> - free_irq(pdev->irq, netdev); > >>> - > >>> pci_disable_device(pdev); > >>> + free_irq(pdev->irq, netdev); > >>> pci_set_power_state(pdev, PCI_D3hot); > >>> =20 > >>> return 0; > >>> @@ -2848,8 +2847,6 @@ static void e100_shutdown(struct pci_dev > >>> pci_enable_wake(pdev, PCI_D3cold, 0); > >>> } > >>> =20 > >>> - free_irq(pdev->irq, netdev); > >>> - > >>> pci_disable_device(pdev); > >>> pci_set_power_state(pdev, PCI_D3hot); > >>> } > >>> _ > >>> > >>> fix it? > >>> > >>>> Hmm ... after resume device has disappeared at all ... > >>>> > >>>> {pts/1}% cat /proc/interrupts > >>>> CPU0 > >>>> 0: 1290492 XT-PIC-XT timer > >>>> 1: 6675 XT-PIC-XT i8042 > >>>> 2: 0 XT-PIC-XT cascade > >>>> 3: 2 XT-PIC-XT > >>>> 4: 2 XT-PIC-XT > >>>> 5: 3 XT-PIC-XT > >>>> 7: 4 XT-PIC-XT irda0 > >>>> 8: 0 XT-PIC-XT rtc0 > >>>> 9: 583 XT-PIC-XT acpi > >>>> 10: 2 XT-PIC-XT > >>>> 11: 31483 XT-PIC-XT yenta, yenta, yenta, ohci_hcd:us= b1, ALI 5451, pcmcia0.0 > >>>> 12: 28070 XT-PIC-XT i8042 > >>>> 14: 21705 XT-PIC-XT ide0 > >>>> 15: 82123 XT-PIC-XT ide1 > >>>> NMI: 0 Non-maskable interrupts > >>>> TRM: 0 Thermal event interrupts > >>>> SPU: 0 Spurious interrupts > >>>> ERR: 0 > >>> I hope that's not a separate bug... > >> I'll take a look at this as well. thanks for reporting. > >=20 > > ok, I just had a repro - on a regular shutdown even. > >=20 > > this always worked before - I'm not blaming anything yet but something = in the pci > > shutdown code must now be freeing our irq for us (I'm not using anythin= g fancy to > > autoconfigure my network here). > >=20 > > I definately do not see this with 2.6.24 either. >=20 > can you try this patch please? It rewrites e100 to do suspend/shutdown ju= st like > e1000e does, which is much more tested than anything else. I don't get th= e IRQ > message anymore - but I haven't gotten to testing suspend/resume just yet. >=20 Yes it fixes it. --nextPart9869805.M9Ff8evE17 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (GNU/Linux) iEYEABECAAYFAke91RgACgkQR6LMutpd94zUQwCglyLlttZkss/qRuzS/+x+/Xdb S7cAn216tIJ0oekwDbIB4kLv4UDM6lCl =nQ0T -----END PGP SIGNATURE----- --nextPart9869805.M9Ff8evE17-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/