Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934683AbYBUVeU (ORCPT ); Thu, 21 Feb 2008 16:34:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933722AbYBUVeB (ORCPT ); Thu, 21 Feb 2008 16:34:01 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:55746 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933762AbYBUVd7 (ORCPT ); Thu, 21 Feb 2008 16:33:59 -0500 Date: Thu, 21 Feb 2008 13:33:45 -0800 From: Greg KH To: Willy Tarreau Cc: David Newall , Linux Kernel Mailing List Subject: Re: [PATCH] 2.4: Back-port of pl2303.c from 2.6.24.1 Message-ID: <20080221213345.GB24191@kroah.com> References: <479A83DE.8020002@davidnewall.com> <20080202074406.GA31516@1wt.eu> <47A46BF8.6030306@davidnewall.com> <47BDDD4E.1080000@davidnewall.com> <20080221203640.GA21764@kroah.com> <20080221210058.GA27541@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080221210058.GA27541@1wt.eu> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2351 Lines: 51 On Thu, Feb 21, 2008 at 10:00:58PM +0100, Willy Tarreau wrote: > Hi Greg, Hi David, > > On Thu, Feb 21, 2008 at 12:36:40PM -0800, Greg KH wrote: > > On Fri, Feb 22, 2008 at 06:51:34AM +1030, David Newall wrote: > > > Hi Willy, > > > > > > Lacking hardware for a week, I've had a bit of a hiatus from PL2303, but > > > I've got it back again now, and finished my work back-porting the 2.6 > > > driver to 2.4. Here's a new patch, which is more complete than my > > > previous one. It's based on the 2.6.24.1. > > > > > > There's a lot of trivial white-space changes and some things that have > > > been moved, which make the patch rather larger than it could be. I > > > didn't include those changes before, but have now in order that the > > > driver be closer to the 2.6 driver. It'll never be identical, of course. > > > > > > Note, too, that the 2.6 driver (and thus the patched 2.4) includes a 1k > > > circular buffer which rather duplicates a buffer in the 2.4 usbserial.c; > > > 2.6's usb-serial has had that buffer removed. As the buffer resolves > > > loss of the occasional putchar (e.g. from n_tty's opost), it is > > > important and correct, even in 2.4. > > > > > > Speaking as a user, I no longer see any problems with PL2303, and I > > > think this is okay to release. > > > > If this works for you, I have no objection to it, but I can't test it as > > I don't run 2.4 on anything anymore :) > > I too agree to merge, it especially since it fixed several problems > for David. However, I would like to know first if the same problems > also happen with the 2.6 driver or if it is OK. The risk is getting > 2.4 fixed and not 2.6, which could cause regressions for people upgrading > from 2.4 to 2.6. Of course, a regression on a USB-serial adapter is > not dramatic, but it's a general principle to keep in mind that 2.6 > should be safe (or at least actively being fixed) when merging driver > changes in 2.4. As far as I can tell, this was a backport of the current 2.6 driver, so it should not have fixes that are not already in 2.6. David, is that true? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/