Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935536AbYBUWn5 (ORCPT ); Thu, 21 Feb 2008 17:43:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763265AbYBUWnk (ORCPT ); Thu, 21 Feb 2008 17:43:40 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:49762 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932299AbYBUWni (ORCPT ); Thu, 21 Feb 2008 17:43:38 -0500 Date: Thu, 21 Feb 2008 14:43:15 -0800 From: Greg KH To: Alexey Dobriyan Cc: Linus Torvalds , Adrian Bunk , Roland Dreier , Glenn Streiff , Faisal Latif , linux-kernel@vger.kernel.org, general@lists.openfabrics.org, Andrew Morton Subject: Re: Merging of completely unreviewed drivers Message-ID: <20080221224315.GA27640@kroah.com> References: <5E701717F2B2ED4EA60F87C8AA57B7CC0794FFF1@venom2> <5E701717F2B2ED4EA60F87C8AA57B7CC0794FFFF@venom2> <20080221154951.GA28328@cs181133002.pp.htv.fi> <20080221210124.GD28328@cs181133002.pp.htv.fi> <20080221223303.GD1846@martell.zuzino.mipt.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080221223303.GD1846@martell.zuzino.mipt.ru> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1033 Lines: 23 On Fri, Feb 22, 2008 at 01:33:03AM +0300, Alexey Dobriyan wrote: > On Thu, Feb 21, 2008 at 01:14:55PM -0800, Linus Torvalds wrote: > > Quite frankly, I've several times been *this* close (holds up fingers so > > you can't even see between them) to just remove checkpatch entirely. > > Agrh! What stopped you?! > > > I'm personally of the opinion that a lot of checkpatch "fixes" are > > anything but. That mainly concerns fixing overlong lines (where the > > "fixed" version is usually worse than the original), but it's been true > > for some other warnings too. > > Speaking of driver, could authors please comment all those barrier() > calls and remove trailing "return;" at the end of void functions. Why don't you make a patch to checkpatch.pl for those types of things? :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/