Date: Fri, 22 Feb 2008 10:46:28 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Glauber Costa <glommer@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, Glauber Costa <gcosta@redhat.com>,
       linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
       arjan@infradead.org
Subject: Re: [PATCH 2/2] make work have a static address in do_boot_cpu()
Message-ID: <20080222094628.GB6269@elte.hu>
References: <1203626456-3101-1-git-send-email-gcosta@redhat.com> <1203626456-3101-2-git-send-email-gcosta@redhat.com> <1203626456-3101-3-git-send-email-gcosta@redhat.com> <1203631967.6112.16.camel@lappy> <5d6222a80802211457s2beb4d5cre331bc800c28d111@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5d6222a80802211457s2beb4d5cre331bc800c28d111@mail.gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 829
Lines: 28


* Glauber Costa <glommer@gmail.com> wrote:

> >  Looks way overkill. Doesn't something like:

> >  >       struct create_idle create_idle = {
> >  > -             .work = __WORK_INITIALIZER(create_idle.work, do_fork_idle),
> >  >               .cpu = cpu,
> >  >               .done = COMPLETION_INITIALIZER_ONSTACK(create_idle.done),
> >  >       };
> >  > +     INIT_WORK(&create_idle.work, do_fork_idle);
> >
> >  work?
> 
> Indeed.
> 
> I missed the static lock_class_key definition inside INIT_WORK macro. 
> It does the job neatly.

could you resend the updated patch?

	Ingo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/