Date: Fri, 22 Feb 2008 10:10:16 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Ray Lee" <ray-lk@madrabbit.org>
Cc: "Greg KH" <gregkh@suse.de>, "Adrian Bunk" <bunk@kernel.org>,
       linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: usb/serial/io_ti.c: inconsequent NULL checking
Message-ID: <20080222101016.37128803@core>
In-Reply-To: <2c0942db0802191538k79f93ca5p93a1883a449f3bb0@mail.gmail.com>
References: <20080219224915.GN31955@cs181133002.pp.htv.fi>
	<20080219232556.GB1963@suse.de>
	<2c0942db0802191538k79f93ca5p93a1883a449f3bb0@mail.gmail.com>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 662
Lines: 22

> Either the test of port->tty here is unneeded:
> 
>  if (port->tty)
>                port->tty->low_latency = low_latency;
> 
> ...or the lack of test of port->tty here is a mistake:
> 
> 	 edge_set_termios (port, port->tty->termios);

Interesting - so coverity doesn't understand the BKL. It's producing the
right answer, for the right reason but the assumption it makes isn't 100%
safe.

The check can go.

Alan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/