Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758729AbYBWCIp (ORCPT ); Fri, 22 Feb 2008 21:08:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752429AbYBWCIf (ORCPT ); Fri, 22 Feb 2008 21:08:35 -0500 Received: from smtp1.linux-foundation.org ([207.189.120.13]:59413 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636AbYBWCIe (ORCPT ); Fri, 22 Feb 2008 21:08:34 -0500 Date: Fri, 22 Feb 2008 18:07:56 -0800 (PST) From: Linus Torvalds To: "Rafael J. Wysocki" cc: Jesse Barnes , Jeff Chua , Romano Giannetti , Dave Airlie , Greg KH , lkml , linux-acpi@vger.kernel.org, Pavel Machek , Alexey Starikovskiy , pm list Subject: Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.) In-Reply-To: <200802230255.54510.rjw@sisk.pl> Message-ID: References: <200802230031.20292.rjw@sisk.pl> <200802230255.54510.rjw@sisk.pl> User-Agent: Alpine 1.00 (LFD 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 856 Lines: 28 On Sat, 23 Feb 2008, Rafael J. Wysocki wrote: > > In the revised patch below I redefined the PM_EVENT_* things as flags so > that I can "or" them and defined PM_EVENT_SLEEP in analogy with > CONFIG_PM_SLEEP. Ok, looks fine by me. > > Didn't you miss the apci_pci_choose_state() thing that also needs this > > extension? > > No, I didn't. That one operates on the ACPI D* states. Ok. I consider that just about the worst interface ever, but whatever... > OK, please have a look at the modified patch below. All right, I'm fine with it. Now we just need to confirm that it works for people.. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/