Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764688AbYBWIF7 (ORCPT ); Sat, 23 Feb 2008 03:05:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762066AbYBWIDw (ORCPT ); Sat, 23 Feb 2008 03:03:52 -0500 Received: from smtp1.linux-foundation.org ([207.189.120.13]:38405 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761790AbYBWIDt (ORCPT ); Sat, 23 Feb 2008 03:03:49 -0500 Date: Sat, 23 Feb 2008 00:02:43 -0800 From: Andrew Morton To: "Serge E. Hallyn" Cc: lkml , Andrew Morgan Subject: Re: [PATCH 1/1] file capabilities: simplify signal check Message-Id: <20080223000243.e6efb30f.akpm@linux-foundation.org> In-Reply-To: <20080220161550.GA14630@sergelap.austin.ibm.com> References: <20080220161550.GA14630@sergelap.austin.ibm.com> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1512 Lines: 40 On Wed, 20 Feb 2008 10:15:50 -0600 "Serge E. Hallyn" wrote: > >From bd076c7245d02be0cc01b7c09bd7170ec5946492 Mon Sep 17 00:00:00 2001 > From: Serge E. Hallyn > Date: Sun, 17 Feb 2008 20:28:07 -0500 > Subject: [PATCH 1/1] file capabilities: simplify signal check > > Simplify the uid equivalence check in cap_task_kill(). Anyone > can kill a process owned by the same uid. > > Without this patch wireshark is reported to fail. Strange that a patch titled "simplify...." actually fixes a bug. > Signed-off-by: Serge E. Hallyn > Signed-off-by: Andrew G. Morgan > --- > security/commoncap.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/security/commoncap.c b/security/commoncap.c > index 5aba826..bb0c095 100644 > --- a/security/commoncap.c > +++ b/security/commoncap.c > @@ -552,7 +552,7 @@ int cap_task_kill(struct task_struct *p, struct siginfo *info, > * allowed. > * We must preserve legacy signal behavior in this case. > */ > - if (p->euid == 0 && p->uid == current->uid) > + if (p->uid == current->uid) > return 0; > > /* sigcont is permitted within same session */ I've marked this as needed-in-2.6.24. Was that appropriate? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/