Date: Sat, 23 Feb 2008 00:05:35 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Liam Girdwood <lg@opensource.wolfsonmicro.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
       Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 3/6] regulator: platform level interface.
Message-Id: <20080223000535.ca36d562.akpm@linux-foundation.org>
In-Reply-To: <1203527345.4071.91.camel@localhost.localdomain>
References: <1203527345.4071.91.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1678
Lines: 50

On Wed, 20 Feb 2008 17:09:05 +0000 Liam Girdwood <lg@opensource.wolfsonmicro.com> wrote:

> This interface configures a regulator for use within a specific device. It
> allows for the creation of voltage and current domains (with constraints) for
> each regulator. Regulator constraints help prevent device damage by providing
> protection for over voltage or over current events caused by buggy client
> drivers.
> 
> This interface also allows the creation of a regulator tree whereby some
> regulators are supplied by others (similar to a clock tree). This means a
> parent regulator will be enabled before it's children are enabled and
> disabled after it's children have all been disabled.
> 
> ...
>
> +/**
> + * struct regulation_constraints - regulator operating constraints.
> + *
> + * This struct describes regulator and board/machine specific constraints.
> + */
> +struct regulation_constraints {
> +
> +	char *name;
> +
> +	/* voltage output range - for voltage control */
> +	int min_uV;
> +	int max_uV;
> +
> +	/* current output range - for current control */
> +	int min_uA;
> +	int max_uA;

It might be worth mentioning whether these are inclusive or exclusive limits.

> +	/* valid regulator operating modes for this machine */
> +	unsigned int valid_modes_mask;
> +
> +	/* valid operations for regulator on this machine */
> +	unsigned int valid_ops_mask;
> +
> +	/* input voltage */
> +	int input_uV;
> +};
> +

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/