Date: Sat, 23 Feb 2008 11:01:40 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Joe Perches <joe@perches.com>
Cc: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>, hpa <hpa@zytor.com>,
       tglx <tglx@linutronix.de>, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 20/20] x86: Coding Style fixes to
	arch/x86/xen/multicalls.c
Message-ID: <20080223100140.GA23833@elte.hu>
References: <20080222231159.34dd5b5a@paolo-desktop> <1203720217.19319.99.camel@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1203720217.19319.99.camel@localhost>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 750
Lines: 21


* Joe Perches <joe@perches.com> wrote:

> >  			printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
> >  			       ret, smp_processor_id());
> > -			for(i = 0; i < b->mcidx; i++) {
> > +			for (i = 0; i < b->mcidx; i++) {
> >  				printk("  call %2d/%d: op=%lu arg=[%lx] result=%ld\n",
> 
> The printk needs a KERN_ERR prefix

yes - but we prefer to isolate the "does not change the .o in any way" 
cleanups from cleanups that materially change kernel behavior. (such as 
printing something else)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/