Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755844AbYBWL5u (ORCPT ); Sat, 23 Feb 2008 06:57:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751237AbYBWL5m (ORCPT ); Sat, 23 Feb 2008 06:57:42 -0500 Received: from courier.cs.helsinki.fi ([128.214.9.1]:60844 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbYBWL5m (ORCPT ); Sat, 23 Feb 2008 06:57:42 -0500 Date: Sat, 23 Feb 2008 13:57:39 +0200 (EET) From: Pekka J Enberg To: Alexey Zaytsev cc: Ingo Molnar , Michael Buesch , Alexey Zaytsev , Greg KH , linux-kernel@vger.kernel.org, Andrew Morton , Linus Torvalds , linville@tuxdriver.com, davem@sunset.davemloft.net Subject: Re: bcm43xx regression in 2.6.24 (with patch) In-Reply-To: Message-ID: References: <47BEAF3B.3080809@protei.ru> <200802221513.58608.mb@bu3sch.de> <47BF101F.30301@protei.ru> <200802221848.37902.mb@bu3sch.de> <20080223110751.GN23833@elte.hu> <84144f020802230318hec5fe97h84c797a56b0dd5db@mail.gmail.com> <20080223112436.GA31304@elte.hu> <84144f020802230337s35c72b50wf8b892777bff42a2@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1142 Lines: 29 Hi Alexey, On Sat, Feb 23, 2008 at 2:37 PM, Pekka Enberg wrote: > > So does reverting commit 753f492093da7a40141bfe083073400f518f4c68 > > ("[B44]: port to native ssb support") fix the regression? > > On Sat, 23 Feb 2008, Alexey Zaytsev wrote: > Compiling it right now. > > I'm sure it fixes the problem, but I don't feel like we should revert > it. I can't > be sure it won't cause any other problems, and anyway, this does not look > right a solution. Any other driver (rightfully) requiring the SSB_HOST would > then also break the bcm43xx driver. > > I'll send an simplified patch in a few minutes. The point here is that it's Michael's patch and I don't want to start blaming anyone until you've verified it actually broke your setup. And if the problem was actually caused by that patch, Michael needs to either ACK your patch or fix it himself. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/