Date: Sun, 24 Feb 2008 02:31:13 +0100
From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: ?ric Piel <Eric.Piel@tremplin-utc.net>, len.brown@intel.com,
       Christoph Hellwig <hch@lst.de>, dsdt@gaugusch.at,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, trenn@suse.de
Subject: Re: [PATCH] Use userland-like functions for reading the ACPI table
Message-ID: <20080224013113.GA12512@lst.de>
References: <20080210071226.GA23360@lst.de> <20080210071454.GA23428@lst.de> <47AEE6D1.4070402@tremplin-utc.net> <20080212053730.GA15347@lst.de> <47BDC705.6090902@tremplin-utc.net> <47C07536.6040404@tremplin-utc.net> <alpine.LFD.1.00.0802231232280.21332@woody.linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LFD.1.00.0802231232280.21332@woody.linux-foundation.org>
User-Agent: Mutt/1.3.28i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1432
Lines: 30

On Sat, Feb 23, 2008 at 12:45:38PM -0800, Linus Torvalds wrote:
> > 
> > As recommended by Christoph Hellwig, even if we can't rely on the userspace
> > firmware loader so early at boot, at least use normal syscall (as in
> > init/do_mounts_*.c). Similarly, use kfree() instead of ACPI_FREE().
> 
> So I'm missing a lot of the background here.
> 
> I don't think "sys_open()" is in any way preferable to the alternatives, 
> especially since it depends on thread-global state (the file descriptor 
> table) rather than much more local state ("struct file" that you've 
> opened).
> 
> I think the calls to sys_open() in init do_dounts etc are very different: 
> they really are more about a real kernel-level almost-user-mode thread 
> than a core driver. 

Well, that's what this code is like aswell.  That's why I recommended
to Eric to move it to init/ and make it look like that code.  I haven't
quite caught up with the discussion yet, but Eric think moving it
there might not be a that good idea.  Having this code in drivers/
even if it's just called in init time is a bad idea, as people will
copy it.  Then again using the functions the code was using before
isn't any better.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/