Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758089AbYBXCGT (ORCPT ); Sat, 23 Feb 2008 21:06:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753680AbYBXCGJ (ORCPT ); Sat, 23 Feb 2008 21:06:09 -0500 Received: from el-out-1112.google.com ([209.85.162.182]:20830 "EHLO el-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753986AbYBXCGI (ORCPT ); Sat, 23 Feb 2008 21:06:08 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=NFWumKkwrO07tm7WxLy3rumi9EcCwGUb2/b4b+Yp5RaL19SHGPBNZ5sYfFFgZu5LUMCoySPkX/uviB68NzAOyBBHDEWQECpokBlpniTYBmXZfaZoXn2+N0fOkvLLPP6T5A2i5Xyre53pTstoeZ9wn0sNKbLiRAGctnAzBJIceIc= Message-ID: Date: Sat, 23 Feb 2008 19:06:06 -0700 From: "Dan Williams" To: "Kumar Gala" Subject: Re: dma engine drivers for 2.6.25? Cc: "LKML Kernel" , "Zhang Wei" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-Google-Sender-Auth: 3400d7c1182091a0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2297 Lines: 58 On Thu, Feb 14, 2008 at 10:29 PM, Dan Williams wrote: > On Thu, Feb 14, 2008 at 8:44 PM, Kumar Gala wrote: > > > > On Feb 14, 2008, at 12:14 PM, Dan Williams wrote: > > > > > On Wed, Feb 13, 2008 at 8:52 PM, Kumar Gala > > > wrote: > > >> Dan, > > >> > > >> What's going on with the dma engine drivers for 2.6.25? We had a > > >> Freescale dma driver from Zhang Wei queued up but seems to have been > > >> lost. > > > > > > I pulled it into my tree and am holding it until Zhang has an > > > opportunity to address the pending review comments [1]. I also did > > > not feel comfortable pushing it to Linus without a PPC maintainer's > > > Acked-by/Reviewed-by. > > > > > > I have attached the version I am carrying. > > > > What issues are still open. I was under the belief that Zhang had > > resolved all the issues. > > > > The high priority review item is that the driver performs operation > completion callbacks in hardirq context. Clients of the API assume > that callbacks will happen in softirq context. Of lesser concern is > the use of GFP_ATOMIC in fsl_dma_alloc_descriptor. Other drivers > preallocate a small pool of descriptors. > Have not received a response, so let's try this the other way. I took a closer look and found that my concern should be addressed by the following one-liner: diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 902e852..cc9a681 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -685,7 +685,6 @@ static irqreturn_t fsl_dma_chan_do_interrupt(int irq, void *data) "nlndar 0x%016llx\n", (u64)get_cdar(fsl_chan), (u64)get_ndar(fsl_chan)); stat &= ~FSL_DMA_SR_EOSI; - fsl_chan_ld_cleanup(fsl_chan); } /* If it current transfer is the end-of-transfer, With your ack I'll push the driver plus this fixlet for the current kernel. Regards, Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/