Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758707AbYBXFMK (ORCPT ); Sun, 24 Feb 2008 00:12:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757340AbYBXFLz (ORCPT ); Sun, 24 Feb 2008 00:11:55 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:50445 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbYBXFLy (ORCPT ); Sun, 24 Feb 2008 00:11:54 -0500 Message-ID: <47C0FC94.6030102@garzik.org> Date: Sun, 24 Feb 2008 00:11:48 -0500 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Atsushi Nemoto CC: Haavard Skinnemoen , linux-kernel@vger.kernel.org Subject: Re: [PATCH] macb: Fix speed setting References: <20080221.225054.61509660.anemo@mba.ocn.ne.jp> In-Reply-To: <20080221.225054.61509660.anemo@mba.ocn.ne.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.3 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 829 Lines: 26 Atsushi Nemoto wrote: > Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by > conversion to generic PHY layer in kernel 2.6.23. > > Signed-off-by: Atsushi Nemoto > --- > diff --git a/drivers/net/macb.c b/drivers/net/macb.c > index 81bf005..1d210ed 100644 > --- a/drivers/net/macb.c > +++ b/drivers/net/macb.c > @@ -148,7 +148,7 @@ static void macb_handle_link_change(struct net_device *dev) > > if (phydev->duplex) > reg |= MACB_BIT(FD); > - if (phydev->speed) > + if (phydev->speed == SPEED_100) > reg |= MACB_BIT(SPD); applied -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/