Message-Id: <6.1.1.1.2.20080224082113.01e51e50@192.168.6.12>
Date: Sun, 24 Feb 2008 08:27:30 +0100
To: linux-kernel@vger.kernel.org
From: Roger While <simrw@sim-basis.de>
Subject: Re: [patch 1/2] x86,fpu: split FPU state from task struct
Cc: suresh.b.siddha@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 997
Lines: 28


On Sat, Feb 23, 2008 at 06:34:38PM -0800, Suresh Siddha wrote:
 > Split the FPU save area from the task struct. This allows easy migration
 > of FPU context, and it's generally cleaner. It also allows the following
 > two optimizations:
 >
 > 1) only allocate when the application actually uses FPU, so in the first
 > lazy FPU trap. This could save memory for non-fpu using apps. Next patch
 > does this lazy allocation.
 >
 > 2) allocate the right size for the actual cpu rather than 512 bytes always.
 > Patches enabling xsave/xrstor support (coming shortly) will take advantage
 > of this.

 >  	if (next_p->fpu_counter>5)
 > -		prefetch(&next->i387.fxsave);
 > +		prefetch(FXSAVE(next_p));

Shouldn't that be  prefetch(FXSAVE(next));  ?

Roger


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/