To: =?iso-8859-2?Q?J=F6rn?= Engel <joern@logfs.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>, David Newall <davidn@davidnewall.com>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Adrian Bunk <bunk@kernel.org>, Roland Dreier <rdreier@cisco.com>,
       Glenn Streiff <gstreiff@NetEffect.com>,
       Faisal Latif <flatif@NetEffect.com>, linux-kernel@vger.kernel.org,
       general@lists.openfabrics.org,
       Andrew Morton <akpm@linux-foundation.org>,
       Greg Kroah-Hartman <greg@kroah.com>
Subject: Re: Merging of completely unreviewed drivers
References: <20080221154951.GA28328@cs181133002.pp.htv.fi>
	<adahcg2awag.fsf@cisco.com>
	<20080221210124.GD28328@cs181133002.pp.htv.fi>
	<alpine.LFD.1.00.0802211310370.19896@woody.linux-foundation.org>
	<m3tzk1q3rt.fsf@maximus.localdomain>
	<47BE2985.6020305@davidnewall.com>
	<20080222020615.GE27894@ZenIV.linux.org.uk>
	<m3myptsp8u.fsf@maximus.localdomain>
	<20080222031315.GF27894@ZenIV.linux.org.uk>
	<m38x1c4od1.fsf@maximus.localdomain>
	<20080224074730.GB31293@lazybastard.org>
From: Krzysztof Halasa <khc@pm.waw.pl>
Date: Sun, 24 Feb 2008 15:47:12 +0100
In-Reply-To: <20080224074730.GB31293@lazybastard.org> (=?iso-8859-2?Q?=22J?=
 =?iso-8859-2?Q?=F6rn?= Engel"'s message of "Sun\, 24 Feb 2008 08\:47\:31
 +0100")
Message-ID: <m3ir0ebedr.fsf@maximus.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 767
Lines: 17

J?rn Engel <joern@logfs.org> writes:

> I strongly disagree.  Machine-generated warnings are a great way of
> quickly locating a large amount of questionable code in an otherwise
> overwhelming haystack.  It doesn't even matter much, which warnings you
> look for.  Almost all code checkers find the same hotspots.

I think you misunderstood. Of course I'm not against warnings in
general. I'm rather talking about _authority_ of human vs machine,
in this specific ("measuring" code complexity) case.
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/