Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760165AbYBXS16 (ORCPT ); Sun, 24 Feb 2008 13:27:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756884AbYBXS1b (ORCPT ); Sun, 24 Feb 2008 13:27:31 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:3387 "EHLO spitz.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752434AbYBXS1a (ORCPT ); Sun, 24 Feb 2008 13:27:30 -0500 Date: Sun, 24 Feb 2008 19:21:21 +0100 From: Pavel Machek To: Alan Stern Cc: "Rafael J. Wysocki" , Pierre Ossman , Zdenek Kabelac , Kernel development list , pm list Subject: Re: [Bug 10030] Suspend doesn't work when SD card is inserted Message-ID: <20080224182120.GB3886@ucw.cz> References: <200802240119.51935.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1255 Lines: 41 Hi! > Index: usb-2.6/drivers/base/power/main.c > =================================================================== > --- usb-2.6.orig/drivers/base/power/main.c > +++ usb-2.6/drivers/base/power/main.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > > #include "../base.h" > #include "power.h" > @@ -59,6 +60,13 @@ static DECLARE_RWSEM(pm_sleep_rwsem); > > int (*platform_enable_wakeup)(struct device *dev, int is_on); > > +static struct task_struct *suspending_task; What locking protects this variable? What happens when suspending_task exits? (Hmm, that would probably be bug, anyway?) Or are we running UP when this is accessed? This at least needs a big fat comment. > +bool in_suspend_context(void) > +{ > + return (suspending_task == current); > +} Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/