Date: Mon, 25 Feb 2008 16:53:01 +0100
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Dhaval Giani <dhaval@linux.vnet.ibm.com>, Mike Galbraith <efault@gmx.de>,
       Ingo Molnar <mingo@elte.hu>, Srivatsa Vaddagiri <vatsa@in.ibm.com>,
       linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: revert load_balance_monitor()
Message-ID: <20080225155301.GA6787@osiris.boeblingen.de.ibm.com>
References: <1203942167.6242.142.camel@lappy> <1203949799.4688.9.camel@homer.simson.net> <20080225143518.GA29275@linux.vnet.ibm.com> <1203953282.6242.180.camel@lappy>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1203953282.6242.180.camel@lappy>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1260
Lines: 30

On Mon, Feb 25, 2008 at 04:28:02PM +0100, Peter Zijlstra wrote:
> On Mon, 2008-02-25 at 20:05 +0530, Dhaval Giani wrote:
> Subject: sched: fully revert load_balance_monitor()
> 
> The following commit causes a number of serious regressions:
> 
>   commit 6b2d7700266b9402e12824e11e0099ae6a4a6a79
>   Author: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
>   Date:   Fri Jan 25 21:08:00 2008 +0100
>   sched: group scheduler, fix fairness of cpu bandwidth allocation for task groups
> 
> Namely:
>  - very frequent wakeups on SMP, reported by PowerTop users.
>  - cacheline trashing on (large) SMP
>  - some latencies larger than 500ms
> 
> While there is a mergeable patch to fix the latter, the former issues
> are IMHO not fixable in a manner suitable for .25 (we're at -rc3 now).
> Hence I propose to revert this patch and try again for .26.

I was just about to complain about the frequent wakeups caused by the
original patch.
It's responsible of 70% of wakeups on an otherwise idle system on s390.

Thanks :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/