Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757482AbYBYRwd (ORCPT ); Mon, 25 Feb 2008 12:52:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753969AbYBYRwX (ORCPT ); Mon, 25 Feb 2008 12:52:23 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:48046 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064AbYBYRwW (ORCPT ); Mon, 25 Feb 2008 12:52:22 -0500 Message-ID: <47C30051.3020909@pobox.com> Date: Mon, 25 Feb 2008 12:52:17 -0500 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Ondrej Zary CC: Grant Grundler , Linux Kernel , netdev@vger.kernel.org Subject: Re: [PATCH] de2104x: remove BUG_ON() when changing media type References: <200801262158.12016.linux@rainbow-software.org> <200802181740.44196.linux@rainbow-software.org> <20080225071505.GC26674@colo.lackof.org> <200802251845.51562.linux@rainbow-software.org> In-Reply-To: <200802251845.51562.linux@rainbow-software.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.3 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 25 Ondrej Zary wrote: > When the chip dies (probably because of a bug somewhere in the driver), > de_stop_rxtx() fails and changing the media type crashes the whole machine. > Replace BUG_ON() in de_set_media() with a warning. > > Signed-off-by: Ondrej Zary > > --- linux-2.6.24-orig/drivers/net/tulip/de2104x.c 2008-02-25 18:27:34.000000000 +0100 > +++ linux-2.6.24-pentium/drivers/net/tulip/de2104x.c 2008-02-25 18:34:56.000000000 +0100 > @@ -910,7 +910,8 @@ > unsigned media = de->media_type; > u32 macmode = dr32(MacMode); > > - BUG_ON(de_is_running(de)); > + if (de_is_running(de)) > + printk(KERN_WARNING "%s: chip is running while changing media!\n", de->dev->name); Certainly a sane improvement... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/