Date: Mon, 25 Feb 2008 15:27:43 -0300
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Cc: linux-kernel@vger.kernel.org, len.brown@intel.com
Subject: Re: latest commit on thinkpad_acpi.c 6c231bd5eb07 shows warning
Message-ID: <20080225182743.GA16513@khazad-dum.debian.net>
References: <c4e36d110802241407q4808e3f8n318723a70696fd0d@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c4e36d110802241407q4808e3f8n318723a70696fd0d@mail.gmail.com>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1330
Lines: 31

On Sun, 24 Feb 2008, Zdenek Kabelac wrote:
> Commit 6c231bd5eb07ce546517019f334652b9ecfc329a
> generate this warning:
> 
> drivers/misc/thinkpad_acpi.c: In function 'tpacpi_input_send_tabletsw':
> include/linux/input.h:1290: warning: 'state' is used uninitialized in
> this function
> drivers/misc/thinkpad_acpi.c:1191: note: 'state' was declared here
> drivers/misc/thinkpad_acpi.c: In function 'hotkey_tablet_mode_show':
> drivers/misc/thinkpad_acpi.c:1723: warning: 's' is used uninitialized
> in this function
> 
> I assume typo  here thinkpad_acpi.c:10724 hotkey_get_tablet_mode
> where status should be maybe 's' and local 's' shouldn't be defined at
> all -  just guess?

Erk.  Looks like I tested one branch and did a git-send-email on the other
or something equally pathetic.  Sorry about that.

I will check the entire thing over line by line and send a fix.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/