Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758021AbYBYTCF (ORCPT ); Mon, 25 Feb 2008 14:02:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755236AbYBYTBz (ORCPT ); Mon, 25 Feb 2008 14:01:55 -0500 Received: from out3.smtp.messagingengine.com ([66.111.4.27]:50739 "EHLO out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754555AbYBYTBy (ORCPT ); Mon, 25 Feb 2008 14:01:54 -0500 X-Sasl-enc: ziva/CyXAUi/1/zPHJ2JbfLV7aJxTTRFBcs96hjImFEk 1203966112 Date: Mon, 25 Feb 2008 16:01:49 -0300 From: Henrique de Moraes Holschuh To: Zdenek Kabelac Cc: linux-kernel@vger.kernel.org, len.brown@intel.com Subject: Re: latest commit on thinkpad_acpi.c 6c231bd5eb07 shows warning Message-ID: <20080225190149.GD16513@khazad-dum.debian.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1297 Lines: 28 On Sun, 24 Feb 2008, Zdenek Kabelac wrote: > Commit 6c231bd5eb07ce546517019f334652b9ecfc329a > generate this warning: > > drivers/misc/thinkpad_acpi.c: In function 'tpacpi_input_send_tabletsw': > include/linux/input.h:1290: warning: 'state' is used uninitialized in > this function > drivers/misc/thinkpad_acpi.c:1191: note: 'state' was declared here > drivers/misc/thinkpad_acpi.c: In function 'hotkey_tablet_mode_show': > drivers/misc/thinkpad_acpi.c:1723: warning: 's' is used uninitialized > in this function I can't seem to get these warnings in Debian gcc 4.2.3-1. But the code is broken alright. I will send in a fix in a short while, as it will take a small while to make sure there is nothing else wrong before I send in the fix. I have to figure out how the heck that got past the testing in the first place, as well... -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/